Remove BigInt dependency from OID #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know my BigUint Representation is inefficient for a variety of reasons (most notably usingy byte words instead of 63 bit words and implementing stuff the textbook way instead of efficiently). Yet, creating an OID from an UUID becomes a near-noop. Encoding to ASN.1 took a 50% performance hit. HOWEVER, we're talking nanoseconds here…
I cannot in good conscience go on to implement this properly, because I am just too clumsy and inefficient with this low-level stuff.